test: improve coverage PgVectorEmbeddingDimensionsTests
#3907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxkm
force-pushed
the
test/PgVectorEmbeddingDimensionsTests
branch
from
e4d965f to
7f1ce23
Compare
|
@alxkm Thanks for the PR improving the test coverage. |
| } | ||
|
|
||
| public Builder frequencePenalty(Double frequencyPenalty) { | ||
| public Builder frequencyPenalty(Double frequencyPenalty) { |
There was a problem hiding this comment.
This is recently fixed via 128c45a
There was a problem hiding this comment.
Thanks for letting me know! I see that commit 128c45a addressed some of the issues.
However, this PR is specifically focused on improving test coverage for the PgVectorEmbeddingDimensionsTests class
I've cleaned up the branch to remove any unrelated commits and now it only contains the test improvements.
Signed-off-by: alxkm <[email protected]>
Signed-off-by: alxkm <[email protected]>
alxkm
force-pushed
the
test/PgVectorEmbeddingDimensionsTests
branch
from
38463e2 to
56f65c3
Compare
alxkm
changed the title
PgVectorEmbeddingDimensionsTests
|
Hello @ilayaperumalg, I’ve fixed the incorrect data from the previous merge. Could you please take a look? |
juntae6942
pushed a commit
to juntae6942/spring-ai
that referenced
this pull request
Aug 7, 2025
…jects#3907) Enhances PgVectorEmbeddingDimensionsTests with additional test cases covering edge scenarios: - Embedding model returning zero/negative dimensions - Explicitly setting zero/negative dimensions via builder - Improved test structure with Given-When-Then comments - Ensures all code paths in embeddingDimensions() method are properly tested. Signed-off-by: alxkm <[email protected]>
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
…jects#3907) Enhances PgVectorEmbeddingDimensionsTests with additional test cases covering edge scenarios: - Embedding model returning zero/negative dimensions - Explicitly setting zero/negative dimensions via builder - Improved test structure with Given-When-Then comments - Ensures all code paths in embeddingDimensions() method are properly tested. Signed-off-by: alxkm <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
…jects#3907) Enhances PgVectorEmbeddingDimensionsTests with additional test cases covering edge scenarios: - Embedding model returning zero/negative dimensions - Explicitly setting zero/negative dimensions via builder - Improved test structure with Given-When-Then comments - Ensures all code paths in embeddingDimensions() method are properly tested. Signed-off-by: alxkm <[email protected]>
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
…jects#3907) Enhances PgVectorEmbeddingDimensionsTests with additional test cases covering edge scenarios: - Embedding model returning zero/negative dimensions - Explicitly setting zero/negative dimensions via builder - Improved test structure with Given-When-Then comments - Ensures all code paths in embeddingDimensions() method are properly tested. Signed-off-by: alxkm <[email protected]> Signed-off-by: 家娃 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances
PgVectorEmbeddingDimensionsTestswith additional test cases covering edge scenarios:Ensures all code paths in
embeddingDimensions()method are properly tested.